fix: BasePath not included in AWS::ApiGateway::BasePathMapping when defined as ["/"] #3740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context, this is the previous PR that contain change that this current PR try to address : #3719 |
|
It's probably better to add new test files instead of modifying the existing ones. It's always good to keep old tests relatively steady, so we can confirm that we're not breaking any of the old cases that were already working fine. |
valerena
reviewed
Mar 25, 2025
valerena
approved these changes
Mar 26, 2025
vicheey
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
The "AWS::Serverless::Api" SAM resource type creates an "AWS::ApiGateway::BasePathMapping" resource when processed.
When the 'BasePath' sub-property of this resource type is defined as ["/"] , the "AWS::ApiGateway::BasePathMapping" resource in the processed template does NOT include the 'BasePath' property.
Description of changes
transform ["/"] into "" in the processed template.
Description of how you validated changes
Updated unit tests to cover the edge case
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.